Repository navigation
Increase max AST depth and throw error if exceeded - #3250
Merged
Merged
Conversation
danmar
approved these changes
May 6, 2021
danmar
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, can be merged when CI is happy..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing gzip's sources on my system, I got a an internalAstError saying
AST broken, ternary operator missing operand(s).It turns out that a file from gnulib exceeds the limit of
AST_MAX_DEPTH, specifically float+.h has a macro with deeply nested ternary operators.This PR doubles the value of
AST_MAX_DEPTHand makes the code throw immediately with a clearer error message if it is exceeded instead of causing hard-to-follow errors down the line. If this behavior is not desired I would suggest at least maintaining a flag indicating whether the maximum depth was exceeded which can then be reported with other internalAstErrors to help diagnosis.